[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

This revision was automatically updated to reflect the committed changes. Closed by commit rL356361: Reinitialize UnwindTable when the SymbolFile changes (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah, I'm ok with this, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added a comment. Since unwinding is Jason's thing, he should give the ok for this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added a comment. In D58347#1424745 , @labath wrote: > Greg, what do you make of this patch? Do you still want me to clear the > unwind table instead of resetting it? No, Jason seems ok with it so I am good. CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath added a comment. Greg, what do you make of this patch? Do you still want me to clear the unwind table instead of resetting it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___ lldb-commits

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); +

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); +

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); + Are we sure no one is holding onto inf

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath created this revision. labath added reviewers: clayborg, jasonmolenda. Herald added a reviewer: alexshap. Herald added a subscriber: jdoerfert. This is a preparatory step to enable adding of unwind plans by symbol file plugins. Although at the surface it seems that currently symbol files h