[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Target/Process.cpp:2639 + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { clayborg wrote: > S

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

clayborg added inline comments. Comment at: source/Target/Process.cpp:2639 + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { So if you have a target that is set to "aarch64-linux-androi

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Target/Process.cpp:2638-2639 } - ModuleSP module_sp(new Module(file_spec, ArchSpec())); + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchit

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

clayborg added inline comments. Comment at: source/Target/Process.cpp:2638-2639 } - ModuleSP module_sp(new Module(file_spec, ArchSpec())); + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { -

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai added a comment. In D58405#1402908 , @aprantl wrote: > > a good guess is the triple that the target executable was compiled for. > > What does this do when the executable has multiple slices, such as a Mach-O > universal binary? Hmm, I hadn't

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

aprantl added a comment. > a good guess is the triple that the target executable was compiled for. What does this do when the executable has multiple slices, such as a Mach-O universal binary? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai created this revision. xiaobai added reviewers: clayborg, zturner, JDevlieghere, compnerd, aprantl, labath. Herald added a subscriber: jdoerfert. While debugging an android process remotely from a windows machine, I noticed that the modules constructed from an object file in memory only h