[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

This revision was automatically updated to reflect the committed changes. Closed by commit rL355249: [Reproducers] Capture and replay interpreter commands. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere added a comment. Addressed in commit. Thank you Pavel! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58564/new/ https://reviews.llvm.org/D58564 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath accepted this revision. labath added a comment. I have a couple of more comments, including some things I missed on the previous pass, but I don't want to hold this up any more. Feel free to commit after taking the last batch into consideration. Comment at:

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188932. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Moved the logic into SBDebugger. - Created DataRecorder factory. - Stored DataRecorder as a field in Debugger. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath added a comment. In D58564#1414410 , @JDevlieghere wrote: > Thanks Pavel. I've updated the patch with your suggestion. I agree it's a lot > better :-) > > I implemented the logic in the Debugger rather than the SBDebugger because I > think the

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188813. JDevlieghere added a comment. Thanks Pavel. I've updated the patch with your suggestion. I agree it's a lot better :-) I implemented the logic in the Debugger rather than the SBDebugger because I think the latter should be a thin wrapper, but

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58564/new/ https://reviews.llvm.org/D58564 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Utility/Reproducer.h

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath added a comment. In D58564#1412674 , @JDevlieghere wrote: > Pavel made a good point that with the previous implementation, the first call > to RunCommandInterpreter would replay every recorded commands. This is indeed > incorrect, because it's

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188617. JDevlieghere added a comment. Pavel made a good point that with the previous implementation, the first call to RunCommandInterpreter would replay every recorded commands. This is indeed incorrect, because it's possible and likely that the state

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath added a comment. In D58564#1410729 , @JDevlieghere wrote: > In D58564#1410213 , @labath wrote: > > > I am sorry that I won't have much time to review this in the next couple of > > weeks, but I don't think

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere added a comment. In D58564#1410213 , @labath wrote: > I am sorry that I won't have much time to review this in the next couple of > weeks, but I don't think this is a good direction here. I don't see how this > will interact with the SB API

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

labath added a comment. I am sorry that I won't have much time to review this in the next couple of weeks, but I don't think this is a good direction here. I don't see how this will interact with the SB API recorder, specifically with things like SBCommandInterpreter::HandleCommand, and

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188286. JDevlieghere added a comment. - Add testcase. - Don't log sourced commands twice. For some reason I thought that we no longer needed to differentiate between commands being sourced from a file. I remember an earlier discussing with Pavel on

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188244. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Add comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58564/new/ https://reviews.llvm.org/D58564 Files:

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

aprantl added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:31 +class CommandProvider; +struct CommandProviderInfo { + static const char *name; Doxygen comments? Comment at:

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, aprantl. JDevlieghere added a project: LLDB. Herald added a subscriber: jdoerfert. Add a provider to the command interpreter. Essentially this writes all the commands to a file which is used during replay as input