[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

aprantl added inline comments. Comment at: include/llvm/BinaryFormat/Minidump.h:26 + +struct Header { + static constexpr uint32_t MagicSignature = 0x504d444d; // PMDM Can you please make sure to Doxygen-ify all the public headers? Repository: rL LLVM CHANGE

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath planned changes to this revision. labath added a comment. Ok, let me try to do that. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

jhenderson added a comment. In D59291#1427349 , @labath wrote: > So, if we want to split this up more, I can propose the following: > > - split off the BinaryFormat&Object changes into a separate patch, test it > with some inline C char arrays > - write t

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath added a comment. The BinaryFormat changes are basically just defining a bunch of structs and enums, so there isn't much to test there. The only actual functional change there is the addition of the magic recognition code in Magic.cpp. That could easily be unit-tested, but that would test

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

jhenderson added a comment. Is it possible to unit-test some of the Object and BinaryFormat changes? That would allow you to split those parts away from the obj2yaml changes. Also, if you added support in yaml2obj, you could test that, then use that in testing the obj2yaml changes more easily,

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath created this revision. labath added reviewers: Bigcheese, jhenderson, zturner. Herald added subscribers: fedor.sergeev, mgorny, dschuff, srhines. Herald added a project: LLVM. This commit adds enough code to be able to dump a simple minidump (a windows "core" file) file into yaml. It consis