[Lldb-commits] [PATCH] D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files

2019-03-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. I'd also like to update the output of lldb-instr but I think that'd be better done in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 ___ lldb-commits maili

[Lldb-commits] [PATCH] D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files

2019-03-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Hmm but the tests fail to build for me ;-). I'm going to update this shortly. Comment at: lldb/source/API/SBAddress.cpp:313 + LLDB_REGISTER_METHOD(lldb::SBSymbolContext, SBAddress, GetSymbolContext, + (uint3_t)); + LLDB_REGISTER_M

[Lldb-commits] [PATCH] D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files

2019-03-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. This builds and passes the tests for me. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427