[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

This revision was automatically updated to reflect the committed changes. Closed by commit rL356753: [ObjectYAML] Add basic minidump generation support (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D59482?vs=191653&id=191879#toc Repository: rL LLVM C

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

jhenderson accepted this revision. jhenderson added a comment. Test updates LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://reviews.llvm.org/D59482 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath updated this revision to Diff 191653. labath added a comment. It occurred to me that the "invalid input" test cases could be easily rewritten in lit, as they don't require parsing of the generated binary (because there isn't one). In this update I just port those tests to lit, which enable

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

clayborg added a comment. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://reviews.llvm.org/D59482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath updated this revision to Diff 191508. labath marked 2 inline comments as done. labath added a comment. - rename Text/Hex streams - fix Hex stream size handling and add some tests for it Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://review

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath marked 8 inline comments as done. labath added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:27 +struct Stream { + enum class StreamKind { +Hex, clayborg wrote: > Maybe "Encoding" might be a better name? On it's own I agree Encod

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

clayborg added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:27 +struct Stream { + enum class StreamKind { +Hex, Maybe "Encoding" might be a better name? Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:28 + enum c

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath added reviewers: markmentovai, amccarth. labath added a comment. Thanks for the review. I've added some extra people who should be familiar with the minidump format (in addition to @clayborg, and @zturner, who should also have some knowledge of it), just in case they have any thoughts/su

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM. I don't really know much about the minidump stuff, but the general structure looks fine to me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath updated this revision to Diff 191079. labath marked 11 inline comments as done. labath added a comment. Updating to address review comments (thank you for the super quick turnaround). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://reviews.

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath marked 11 inline comments as done. labath added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:181 + FeaturesRef.writeAsBinary(FeaturesStream); + std::fill(Features.begin(), Features.end(), 0); + std::memcpy(Features.begin(), FeaturesStorage.begin(), -

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

jhenderson added a comment. I've not reviewed the unit test yet, but the bulk of the body looks fine, apart from some minor details. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:27 +struct Stream { + enum StreamKind { +HexKind, I think it is worth m

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath created this revision. labath added reviewers: jhenderson, zturner, clayborg, aprantl. Herald added a subscriber: mgorny. Herald added a project: LLVM. This patch adds the ability to read a yaml form of a minidump file and write it out as binary. Apart from the minidump header and the strea