This revision was automatically updated to reflect the committed changes.
Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow
customizing Import behavior. (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59485?vs=197149&id=197180#
teemperor added a comment.
I'll land this as it seems only the tests are subject to change and I want to
also land the dependencies of this patch. Please let me know if you want any
other changes changes to the test and thanks for the review!
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
teemperor updated this revision to Diff 197149.
teemperor added a comment.
- Refactored test according to Gábor's feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59485/new/
https://reviews.llvm.org/D59485
Files:
clang/include/clang/AST/ASTImporter.h
clang/lib/AST/ASTImporte
martong added inline comments.
Comment at: clang/unittests/AST/ASTImporterTest.cpp:625
+ "class shouldNotBeImported {};", Lang_CXX, "class realDecl {};",
Lang_CXX,
+ "shouldNotBeImported", RedirectingImporter::Constructor);
+ auto *Imported = cast(To);
---
martong accepted this revision.
martong added a comment.
Looks good, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59485/new/
https://reviews.llvm.org/D59485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
teemperor updated this revision to Diff 196955.
teemperor retitled this revision from "[ASTImporter] Add an ImportInternal
method to allow customizing Import behavior." to "[ASTImporter] Add an
ImportImpl method to allow customizing Import behavior.".
teemperor edited the summary of this revision
