[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356469: Remove a couple of log statements. (authored by zturner, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D594

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

clayborg accepted this revision. clayborg added a comment. I haven't used it in a long time. I can add it back temporarily if I ever need to. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59498/new/ https://reviews.llvm.org/D59498 ___ lldb

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

JDevlieghere accepted this revision. JDevlieghere added a subscriber: davide. JDevlieghere added a comment. This revision is now accepted and ready to land. In D59498#1433421 , @zturner wrote: > In all cases, I think the question worth asking is not "could

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

zturner marked 4 inline comments as done. zturner added a comment. In all cases, I think the question worth asking is not "could it be used for X", but rather "how often is it actually used for X". Otherwise, it's just technical debt IMO. There's a lot of things that are possible in theory, bu

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

clayborg added a comment. Most of these logs seem useful. See inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp:121-144 - Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES)); - size_t orig_arange_size = 0; - if (log) { -o

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

zturner created this revision. zturner added reviewers: JDevlieghere, aprantl. Herald added a subscriber: jdoerfert. I don't find these specific log statements particularly high value, as they appear more just like simple function tracing calls (i.e. they log low level implementation details, no