[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

2019-03-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356927: [Args] Handle backticks to prevent crash. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59779?vs=192131&id=192139#toc Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

2019-03-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D59779#1441705 , @labath wrote: > Given the current way lldb command interpreter parser does things (which > tries to model a posix shell), (one of) the correct ways to do `'`-quoting > would be to replace each `'` char b

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

2019-03-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Given the current way lldb command interpreter parser does things (which tries to model a posix shell), (one of) the correct ways to do `'`-quoting would be to replace each `'` char by `'\''`. However, this isn't the only problem with how we do tab-completion of quoted

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

2019-03-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, zturner, davide. Herald added a subscriber: jdoerfert. Herald added a project: LLDB. Currently LLDB crashes when autocompleting a command that ends with a backtick. ./bin/lldb test.tmp.out (lldb) target create "test.tm