This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB358135: [NFC] Remove ASCII lines from comments (authored
by JDevlieghere, committed by ).
Changed prior to commit:
h
labath added a comment.
Let's ship it. :)
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60508/new/
https://reviews.llvm.org/D60508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
sgraenitz added a comment.
+1 Following the local coding style was a pain when adding functions in these
files. Good step forward.
This covers the majority of occurrences. Leaving `unittests` unchanged is
probably intentional. There's a few more left in `tools` and other corners for
a follow-up
teemperor added a comment.
Herald added a subscriber: dexonsmith.
LGTM. Thanks for doing this! These lines are really frustrating to maintain
when writing documentation. Also this should bring us yet again a bit closer to
the LLVM style, so +1 for that.
Repository:
rLLDB LLDB
CHANGES SINCE
JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
Herald added subscribers: jsji, abidh, arphaman, atanasyan, MaskRay, kbarton,
arichardson, javed.absar, ki.stfu, nemanjai, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: jfb.
Herald added a project: LLDB