This revision was automatically updated to reflect the committed changes.
Closed by commit rL359471: Fix a stack-smasher in
PlatformMacOSX::GetSDKDirectory() (authored by adrian, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61218/new/
https://reviews.llvm.org/D61218
__
aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a project: LLDB.
GetSDKVersion expects the number of version fields not their byte size and will
happily overwrite later contents of the stack.
I just found this by accident while stepping through the fun
