[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1489109 , @labath wrote: > I think there is a problem with this patch. I don't believe the TestVLA part > would work on any non-darwin platform (it doesn't on linux: > http://lab.llvm.org:8014/builders/lldb-x86_64-debia

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

labath added a comment. I think there is a problem with this patch. I don't believe the TestVLA part would work on any non-darwin platform (it doesn't on linux: http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/923), and it works on darwin only accidentally. The reason the fails on l

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL359841: Hide runtime support values such as clang's __vla_expr from frame variable (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197871. aprantl added a comment. Thanks you! There was indeed a bug that prevented us from recognizing the correct runtime for the C++ `this` pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files:

Re: [Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

If we did this wrong, then either stopping in a C++ method in a .mm file would suppress "this" (if we mistakenly used the ObjC Runtime's "RuntimeSupportValue") or stopping in an ObjC method in a .mm file would suppress "self and _cmd" (if we used the C++ Runtime's RuntimeSupportValue). So we n

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files: lldb/include/lldb/Target/CPPLanguageRuntime.h lldb/include/lldb/Target/LanguageRuntime.h lldb/include/lldb/Target/ObjCLanguageRuntime.h ll

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1488186 , @jingham wrote: > Could you add a comment (probably best in LanguageRuntime.h) saying what a > RuntimeSupportValue is? Done. > Also, so far as I can tell, this patch works because we use the CPP language >

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

jingham added a comment. Could you add a comment (probably best in LanguageRuntime.h) saying what a RuntimeSupportValue is? Also, so far as I can tell, this patch works because we use the CPP language runtime for C++ methods is an ObjC++ file, and the ObjCLanguageRuntime for ObjC methods in di

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl created this revision. aprantl added a reviewer: jingham. Herald added a project: LLDB. by respecting the "artificial" attribute on variables. Function arguments that are artificial and useful to end-users are being whitelisted by the language runtime. Repository: rG LLVM Github Mono