[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

2019-05-06 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r360067 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61543/new/ https://reviews.llvm.org/D61543 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

2019-05-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This looks much better, though I'd just change one tiny thing: in the macro "canonicalization" step, I'd define a custom macro, instead of reusing one of the system ones (`_M_ARM` and friends), as those are reserved identifiers and it's bad

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

2019-05-03 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61543/new/ https://reviews.llvm.org/D61543 ___ lldb-com

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

2019-05-03 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd created this revision. compnerd added reviewers: labath, xiaobai, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. The debug server does not need to use the instruction emulation. This helps reduce the size of the final lldb-server binary by another ~100K (~1% s