[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D61578#1493875 , @labath wrote: > In D61578#1493863 , @jingham wrote: > > > The dotest.py tests all disable reading the global .lldbinit file. Do the > > lit tests not do that as well?

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D61578#1493863 , @jingham wrote: > The dotest.py tests all disable reading the global .lldbinit file. Do the > lit tests not do that as well? For tests that actually test reading the > user's .lldbinit file we will need to do

Re: [Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Jonas Devlieghere via lldb-commits
On Tue, May 7, 2019 at 10:33 AM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > In D61578#1493452 , @labath > wrote: > > > In D61578#1492422 , > @JDevlieghere wrote: > > >

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D61578#1493452 , @labath wrote: > In D61578#1492422 , @JDevlieghere > wrote: > > > In D61578#1492086 , @clayborg > > wrote: > > > > > Just wante

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360172: [Driver] Add command line option to allow loading local lldbinit file. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-07 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D61578#1492422 , @JDevlieghere wrote: > In D61578#1492086 , @clayborg wrote: > > > Just wanted to verify th

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 198334. JDevlieghere added a comment. Make it clear that --no-lldbinit supersedes the new flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61578/new/ https://reviews.llvm.org/D61578 Files: lldb/lit/Driver/LocalLLDBInit.test lldb/tools/d

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D61578#1492086 , @clayborg wrote: > Just wanted to verify that we can put a: > > settings set target.load-cwd-lldbinit true > > > in our ~/.lldbinit file and it will then load the local init file in the > current working

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-06 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Just wanted to verify that we can put a: settings set target.load-cwd-lldbinit true in our ~/.lldbinit file and it will then load the local init file in the current working directory? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/tools/driver/Options.td:94-100 def: Flag<["-"], "x">, Alias, HelpText<"Alias for --no-lldbinit">, Group; +def local_lldbinit: F<"local-lldbinit">, + HelpText<"Allow the

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/tools/driver/Options.td:94-100 def: Flag<["-"], "x">, Alias, HelpText<"Alias for --no-lldbinit">, Group; +def local_lldbinit: F<"local-lldbinit">, + HelpText<"Allow the debugger to load the local lldbinit files.">, + Grou

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

2019-05-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, jingham. Herald added a project: LLDB. JDevlieghere added a parent revision: D61577: [Driver] Change the way we deal with local lldbinit files.. This patch adds a command line flag that allows lldb to load local l