[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

2019-05-08 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360292: Fix bug in ArchSpec::MergeFrom (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D61

[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

2019-05-07 Thread Alex Langford via Phabricator via lldb-commits
xiaobai added a comment. Ah, this was my bad. Thanks for taking care of this. Comment at: unittests/Utility/ArchSpecTest.cpp:188-193 +EXPECT_EQ(llvm::Triple::ArchType::arm, B.GetTriple().getArch()); +EXPECT_EQ(llvm::Triple::VendorType::UnknownVendor, + B.Ge

[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

2019-05-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, zturner, jingham. Previous ArchSpec tests didn't catch this bug since we never tested just the OS being out of date. Fixed the bug and covered this with a test that would catch this. This was found when trying to load a core file