[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

This revision was automatically updated to reflect the committed changes. Closed by commit rL362173: Make ConnectionFileDescription work with all sockets (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200800. aadsm added a comment. Remove unused variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: lldb/include/lldb/Host/Socket.h lldb/include/lldb/Host/c

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Host/SocketTest.cpp:172-178 + std::unique_ptr socket_a_up; + std::unique_ptr socket_b_up; + if (!IsAddressFamilySupported("127.0.0.1")) { +

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200597. aadsm added a comment. Add missing bits from previous revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: lldb/include/lldb/Host/Socket.h lldb/inc

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200594. aadsm added a comment. Fix the mess I created by including parts of the previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: lldb/include/lldb/H

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. It looks like diff now contains the changes from D61833 as well. It would be better to upload just the changes relative to the previous patch in the series, otherwise things get confusing about what is being changed where. It's kind of o

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200403. aadsm added a comment. Herald added subscribers: jfb, mgorny. - Change GetConnectURI to GetRemoteConnectionURI - Fixes tests when it comes to using dangling pointers on ConstRefs - Better usage of the EXPECT_* macros. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Host/posix/DomainSocket.cpp:130 + +std::string DomainSocket::GetSocketName() const { + if (m_socket != kInvalidSocketValue) { labath wrote: > This should also be `GetRe

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. `GetRemoteConnectionURI` sounds fine. Comment at: lldb/source/Host/posix/DomainSocket.cpp:130 + +std::string DomainSocket::GetSocketName() const { + if (m_socket != kInvalidSocketValue) { This should also be `GetRemoteSocketName` or so

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm marked an inline comment as done. aadsm added a comment. Glad you brought the naming up, I was also not happy with it. I guess I kind of convinced myself in the end with "it's the url the socket used to create its connection". The other name I tinkered with was `GetConnectRemoteURI`, I wan

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. The patch looks fine, modulo some inline nits. I am somewhat doubtful about the name of the new function though. When I first saw `GetConnectURI`, i thought this would be the URI used to connect to `this` socket, but in reality it is the URI of the other end (right?). In

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200126. aadsm added a comment. Avoid parsing the URL when starting the GDB server if it's not a TCP connection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: l

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm added a comment. I'm not really sure which source version lldb-server is being shipped with Android Studio today (since their version works just fine obviously)... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm created this revision. aadsm added reviewers: labath, clayborg, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My main goal here is to make lldb-server work with Android Studio. This is currently not the case because lldb-server is started in platform mode