[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

jingham added a comment. The typical trick for doing argument substitution before debugging was roughly to debug: exec /bin/sh executable arg1 arg2 ... then follow through the shell to the executable. That failed when SIP made it impossible to debug any of the shells, so we had to come up

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL361946: [CMake] LLDB.framework tools handling (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz updated this revision to Diff 201859. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fixed debugserver; excluded changes in add_lldb_library() for now; result of this test looks as good as before: $ cmake -GNinja

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

clayborg added inline comments. Comment at: lldb/tools/darwin-debug/CMakeLists.txt:6 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(darwin-debug) +endif() We need it for launching in a terminal on macOS. So it actually is needed for "process launch --tty"

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/argdumper/CMakeLists.txt:9 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(lldb-argdumper) +endif() friss wrote: >

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

xiaobai added a comment. This is a much nicer solution. Thanks for doing this. Comment at: lldb/tools/debugserver/source/CMakeLists.txt:268 + if(LLDB_BUILD_FRAMEWORK) +lldb_add_to_framework(lldb-argdumper) + endif() This should be `debugserver`.

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz added a comment. Thanks for having a look. I'd to focus on the mechanism here and keep the contents of the framework bundle unchanged. Happy to discuss this in separate reviews like D62474 . Comment at:

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz updated this revision to Diff 201726. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fix copy/paste mistake for darwin-debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62472/new/ https://reviews.llvm.org/D62472

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

friss added inline comments. Comment at: lldb/tools/argdumper/CMakeLists.txt:9 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(lldb-argdumper) +endif() JDevlieghere wrote: > Why do we need this in the framework? Is it only there for testing? It is definitely

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

JDevlieghere added inline comments. Comment at: lldb/tools/argdumper/CMakeLists.txt:9 +if(LLDB_BUILD_FRAMEWORK) + lldb_add_to_framework(lldb-argdumper) +endif() Why do we need this in the framework? Is it only there for testing? Comment at:

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz updated this revision to Diff 201479. sgraenitz added a comment. lldb-vscode is no fremwork tool, but instead it needs the RPATHs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62472/new/ https://reviews.llvm.org/D62472 Files:

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, compnerd, JDevlieghere. Herald added subscribers: mgorny, ki.stfu. Herald added a project: LLDB. Modify the way LLDB.framework tools are collected. This allows for better fine-tuning of the install behavior downstream. Each