[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm abandoned this revision. aadsm added a comment. Replaced by D62503 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 ___

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm added a comment. I looked into this a bit today and at one point in time (when the list of modules is being processed) it seems that some previously loaded modules are somehow removed (at least I stop seeing them in the `image list`) including the one where the rendezvous breakpoint is

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm added a comment. @jankratochvil I imagine the first test to be failing because this patch doesn't handle correctly the unload (or rather as soon as it unloads one shared object it stops working as expected). I'm going to look at this today (right now it's 9am for me). Repository: rG

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

jankratochvil added a comment. So it does fix the massive regression of D62503 similarly as my D63868 but it still has 2 regressions there (=Fedora 30 x86_64, after reapplication of D62503 ), I

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

labath added a comment. Sorry, I missed this patch. Overall, this seems fine to me. I have only two comments about it: - I'm not sure the `CanLoadModules` functions is really needed. It seems like we could just call `LoadModules` directly and check for error result. The `XMLEnabled() && ...`

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

xiaobai added a comment. ping @labath @clayborg any issues with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm updated this revision to Diff 203761. aadsm added a comment. Do not try to use LoadModules again if they failed in the past Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 Files:

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm edited the summary of this revision. aadsm added a parent revision: D62503: Add ReadCStringFromMemory for faster string reads. This is the