labath added a comment.
Thank you for working on this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62570/new/
https://reviews.llvm.org/D62570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368742: [DWARF} Use LLVM's debug line parser in LLDB.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62570?vs=214464&id=214903#toc
Repository:
rL LLVM
JDevlieghere added a comment.
Thank you! I agree that extending the LLVM parser is a good idea, especially if
it's already using a callback internally. I'll add a comment in the code and
spend some time looking at that in the coming days.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6
clayborg added a comment.
I agree with Adrian, this isn't something that needs to hold up this patch, but
I do think it is worth doing soon in LLVM. The line table parsing code just
needs to take a std::function (or llvm equivalent) that gets called like a
lambda when a row is to be pushed. The
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Two percent is a noticeable price tag, but since we are doing extra work with
error handling and building a copy of the line table in memory first;
understandable, I'm moderately optimistic
clayborg added a comment.
Thanks for running the perf tests, that will be great to keep handy somewhere.
Might be good to check this test in somewhere. I still think that making
changes to the llvm line parser might be a good idea where we can get a
callback when a row is to be pushed with the
JDevlieghere added a comment.
I used `image dump line-table` to benchmark the performance difference. I did a
RelWithDebugInfo build of clang and picked 237 files to dump.
repeat 10 "time ./bin/lldb -b -o 'image dump line-table ARCMT.cpp
ARCMTActions.cpp FileRemapper.cpp ObjCMT.cpp PlistRepor
aprantl added inline comments.
Comment at: lldb/include/lldb/Core/FileSpecList.h:29
+ typedef std::vector collection;
+ typedef collection::iterator iterator;
+ typedef collection::const_iterator const_iterator;
JDevlieghere wrote:
> grimar wrote:
> > Seems yo
JDevlieghere updated this revision to Diff 214464.
JDevlieghere added a comment.
Herald added a reviewer: jdoerfert.
Rebase and fix a bug in the support file implementation. I'm not sure why this
didn't manifest itself earlier.
I have a plan to benchmark this (using `image dump line-table`) but
clayborg added a comment.
We also need to test to ensure this doesn't regress parsing speed. Need a large
C++ project, like LLDB with debug clang and debug llvm, and something that
forces all line tables to be parsed (not just the prologues like when setting a
breakpoint) and see how things com
JDevlieghere updated this revision to Diff 210659.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
Keep the indices correct when remapping a file fails.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62570/new/
https://reviews.llvm.org/D62570
Files:
lldb/i
clayborg added a comment.
So in the actual line table parsing code it seems like we are creating a line
table in LLVM format, complete with sequences and a bunch of LLVM data
structures, and then copying the results over into LLDB and then throwing away
the LLVM line table. It would be nicer to
JDevlieghere updated this revision to Diff 210222.
JDevlieghere marked 3 inline comments as done.
JDevlieghere retitled this revision from "[WIP] Use LLVM's debug line parser in
LLDB" to "Use LLVM's debug line parser in LLDB".
JDevlieghere added a comment.
- Address code review feedback
- Fix sup
13 matches
Mail list logo
