This revision was automatically updated to reflect the committed changes.
Closed by commit rL362406: [lldb-server unittest] Add missing teardown logic
(authored by aadsm, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
labath added a comment.
I should add (since I'm guessing you found this problem while trying to add
unit tests for your lldb-server changes) a bit of history about these tests.
There are two kinds of tests for lldb-server. The python tests
(test/testcases/tools/lldb-server) are older ones. The
labath accepted this revision.
labath added a comment.
> Not sure why this isn't failing the build bots.. (unless they're running
> without asserts?).
The build bots (and lit, in general) runs each of the unit tests in isolation
(so it first gets a list of all tests, then runs the executable wi
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62788/new/
https://reviews.llvm.org/D62788
__
aadsm created this revision.
aadsm added reviewers: clayborg, xiaobai, labath.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This test base class is missing the teardown making the second set of tests
extending it to fail in an assertion in the FileSystem::Initialize() (a
