[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL362589: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEF

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz updated this revision to Diff 203030. sgraenitz added a comment. Add CMAKE_EXECUTABLE_SUFFIX when searching for llvm-tblgen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 Files: lldb/cmake/modu

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH) endif() ---

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH) endif() How i

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

xiaobai accepted this revision. xiaobai added a comment. Seems fine to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz added a comment. IIUC Clang uses the same mechanism. Moving `append_configuration_directories()` to AddLLVM.cmake could help there too. We may consider it for the future once D62859 is through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 ___

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, labath, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. If the provided LLVM build-tree used a multi-configuration generator like Xcode, `LLVM_TOOLS_BINARY_DIR` will have a generator-specific p