This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL363528: DWARF: Avoid storing DIERefs in long-lived
containers (authored by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-com
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2970
if (die) {
TypeSystem *type_system =
aprantl wrote:
> If you find the time:
>
> ```
> if (!die)
> return {};
>
aprantl added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2970
if (die) {
TypeSystem *type_system =
If you find the time:
```
if (!die)
return {};
auto *type_system = GetTypeSystemForLanguage(die.GetCU()->GetLangu
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63322/new/
https://reviews.llvm.org/D63322
___
lldb-commits mailing list
labath created this revision.
labath added reviewers: clayborg, JDevlieghere.
Herald added a subscriber: aprantl.
A user_id_t carries the same information as a DIERef, but it takes up
less space.
Furthermore, DIERef::operator<'s implementation is very
questionable, as it does not take the cu_offs
