[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny updated this revision to Diff 205999. mgorny added a comment. …and removed stale declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 Files: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp lldb/sourc

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny updated this revision to Diff 205998. mgorny added a comment. Updated to use new XState conversion methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 Files: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:239 + + if (byte_order == lldb::eByteOrderBig) { +::memcpy(m_xstate_x86_64.xs_fxsave.fx_xmm[reg_index].xmm_bytes, labath wrote: > mgorny

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

labath added a comment. In D63545#1551703 , @mgorny wrote: > In D63545#1551681 , @labath wrote: > > > Maybe have GetYMM(unsigned num, YMM& reg)/SetYMM(unsigned num, const YMM > > ®) methods on the XSAVE struct ? >

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny added a comment. In D63545#1551681 , @labath wrote: > In D63545#1551675 , @mgorny wrote: > > > In D63545#1551627 , @labath wrote: > > > > > We have the same XSTATE<->Y

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

labath added a comment. In D63545#1551675 , @mgorny wrote: > In D63545#1551627 , @labath wrote: > > > We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. > > It would be nice to extract them t

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny marked an inline comment as done. mgorny added a comment. In D63545#1551627 , @labath wrote: > We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. It > would be nice to extract them to some common place (Plugins/Process/Utilit

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

labath added a comment. We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. It would be nice to extract them to some common place (Plugins/Process/Utility, I guess :P). The rest seems pretty straight-forward, though you're repeating the patterns that I find really reduntan

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny updated this revision to Diff 205763. mgorny added a comment. Rebased for changes in `NativeRegisterContextNetBSD_x86_64::GetSetForNativeRegNum()`, and removed the conditions there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 Files:

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny created this revision. mgorny added reviewers: krytarowski, labath, JDevlieghere. Herald added a subscriber: emaste. Provide a (conditional) support for the new PT_GETXSTATE and PT_SETXSTATE ptrace() requests, and use them to implement getting and setting YMM registers. The functions used