This revision was automatically updated to reflect the committed changes.
jingham marked an inline comment as done.
Closed by commit rL364686: Get the expression parser to handle missing weak
symbols. (authored by jingham, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: ll
jingham marked 8 inline comments as done.
jingham added inline comments.
Comment at: include/lldb/Symbol/Symbol.h:258
+ m_is_weak : 1,
m_type : 7;
Mangled m_mangled; // uniqued symbol name/mangled name pair
clayborg wrote:
> change to:
> ``
jingham updated this revision to Diff 207146.
jingham added a comment.
Addressed Greg's comments
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63914/new/
https://reviews.llvm.org/D63914
Files:
include/lldb/Expression/IRExecutionUnit.h
include/lldb/Symbol/S
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few nits, but nothing structural. Fix those and this will be good to go.
Comment at: include/lldb/Symbol/Symbol.h:257
jingham created this revision.
jingham added reviewers: JDevlieghere, clayborg.
Herald added subscribers: lldb-commits, teemperor, abidh.
Herald added a project: LLDB.
lldb wasn't handling weak symbols, so if you were debugging a binary that used
a weak symbol, and the symbol was missing, any ref
