[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg. Herald added a subscriber: jdoerfert. When trying to ascertain what language a variable belongs to, just checking the compilation unit is often not enough. In r364845 I added a way to check for a variable's language type, b

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

jingham added a comment. Why did you make this a function of Variable, rather than SymbolContextScope? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. In D64042#1574438 , @jingham wrote: > Why did you make this a function of Variable, rather than SymbolContextScope? After thinking about it more, I realized that the implementation inside of SymbolContextScope would be identical

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sounds reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366733: [Symbol] Improve Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

labath added inline comments. Herald added a reviewer: jdoerfert. Comment at: lldb/trunk/source/Symbol/Variable.cpp:61-69 + if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { +if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) + ret

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/trunk/source/Symbol/Variable.cpp:61-69 + if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { +if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) +