[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor created this revision. teemperor added reviewers: JDevlieghere, davide, sgraenitz. Herald added subscribers: lldb-commits, abidh, mgorny. Herald added a project: LLDB. teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/C

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/OptionsBase.td:11 + // *.inc file. + string Command; +} I'm open to renaming this if anyone has a better name for this. Repository: rLLDB LLDB CHA

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

labath added a comment. I like this, though I am not really familiar with details of implementing a tablegen backend. This should make it easier to migrate to the llvmOption library, once we arrive to that point. Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26 +//

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 208506. teemperor added a comment. - Added comment that std::map is also used to make sure our commands are sorted. - anonymous namespace -> static CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 Files:

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26 +/// Map of command names to their associated records. +typedef std::map> RecordsByCommand; + labath wrote: > llvm::StringMap

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

xiaobai added a comment. This is awesome, thanks for doing this! I was also thinking about doing something like this at some point as well. :) Comment at: lldb/cmake/modules/AddLLDB.cmake:17 + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by clang

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:16 + + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by clang_tablegen") nit: remove the spaces to be consistent. Comment at: lldb/u

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 208539. teemperor marked 3 inline comments as done. teemperor added a comment. - Addressed feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked 5 inline comments as done. teemperor added a comment. Thanks for the feedback! Comment at: lldb/source/Commands/BreakpointList.td:1 +include "Options.td" + xiaobai wrote: > Is BreakpointList.td used? I noticed `hide_aliases` is also implemented

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

jingham added a comment. Do you know how you are going to do enum option values? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked an inline comment as done. teemperor added a comment. In D64365#1574785 , @jingham wrote: > Do you know how you are going to do enum option values? We could implement the enums in our table gen file, but then we would have the enums dup

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Raphael, great job! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 ___

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 209119. teemperor added a comment. - Better formatting and comments for generated Options.inc - Added support and example for arguments that have enum values. - Fixed some typos in the Options.td definitions that caused some tests to fail. CHANGES SINCE LA

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365908: [lldb] Let table gen create command option initializers. (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h