[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() JDevlieghere wrote: > mgorny wrote: > > As a small optimization, I think you can pre

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

amccarth added a comment. OK, the only way I was able to make this work was to remove all traces of Python 2.x from my machine. As long as the older Python existed on my machine CMake would find that one, regardless of which one was in my PATH or indicated by PYTHON_HOME_DIR. Of course, it re

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

amccarth added a comment. In D64812#1588061 , @rnk wrote: > In D64812#1588055 , @rnk wrote: > > > You broke my build. =/ I got this output: > > > > CMake Error at > > C:/src/llvm-project/lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() mgorny wrote: > As a small opti

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() As a small optimization, I think you can prepend major+minor version into `Python_A

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. In D64812#1588055 , @rnk wrote: > You broke my build. =/ I got this output: > > CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 > (message): > Found incompatible Python interpreter (3.7.3) and Python l

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added a comment. In D64812#1588040 , @JDevlieghere wrote: > If that works in `3.4` I'm happy to go that way! FWICS it's been added in 3.12, so no. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/ https://

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. You broke my build. =/ I got this output: CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 (message): Found incompatible Python interpreter (3.7.3) and Python libraries () I'll mess with it a bit I guess. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere added a comment. In D64812#1588030 , @mgorny wrote: > Hmm, I've just looked through CMake docs, and I think a better solution might > be: > > find_package(Python COMPONENTS Interpreter Development) > > > Apparently using separate modules ha

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

This revision was automatically updated to reflect the committed changes. Closed by commit rL366243: [CMake] Fail when Python interpreter doesn't match Python libraries version (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added a comment. Hmm, I've just looked through CMake docs, and I think a better solution might be: find_package(Python COMPONENTS Interpreter Development) Apparently using separate modules has been deprecated in 3.12, and using a single `FindPython` call guarantees version match. Of

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. This definitely caused me some pain a few months ago. Thanks for adding this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere created this revision. JDevlieghere added reviewers: sgraenitz, labath, xiaobai. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. Because of how CMake finds the Python libraries and interpreter, it's possible to end up with a discrepancy between the two. For exa