[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1760 +void RegisterContextLLDB::PropagateTrapHandlerFlag( +lldb::UnwindPlanSP unwind_plan) { + if (unwind_plan->Ge

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JDevlieghere added a comment. In D64993#1612825 , @JosephTremoulet wrote: > In D64993#1612746 , @JDevlieghere > wrote: > > > Hey Joseph, > > > > The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you ple

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. In D64993#1612746 , @JDevlieghere wrote: > Hey Joseph, > > The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you please have > a look? > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/32449/testRepor

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JDevlieghere added a comment. Hey Joseph, The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you please have a look? http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/32449/testReport/junit/LLDB/Unwind/trap_frame_sym_ctx_test/ Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367691: Fix PC adjustment in StackFrame::GetSymbolContext (authored by josepht, committed by ). Herald added a project: LL

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 213067. JosephTremoulet added a comment. - Expand comment about return trampolines - rename PropagateTrapHandlerFlag -> PropagateTrapHandlerFlagFromUnwindPlan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

jasonmolenda accepted this revision. jasonmolenda added a comment. This looks good, this is in line with what we discussed, thanks for taking it on! Sorry for the delay at looking this over, it has been a little crazy this week. Comment at: lldb/source/Plugins/Process/Utilit

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

labath added a comment. In D64993#1608946 , @JosephTremoulet wrote: > In D64993#1608452 , @labath wrote: > > > I haven't looked at the implementation, but I did run into the problem you > > are fixing in the past,

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. In D64993#1608452 , @labath wrote: > I haven't looked at the implementation, but I did run into the problem you > are fixing in the past, and I am happy that someone is finally implementing > this. I just wanted to say th

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 212642. JosephTremoulet added a comment. - add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64993/new/ https://reviews.llvm.org/D64993 Files: lldb/include/lldb/Core/Address.h lldb/include/lld

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg added a comment. Code looks fine now. Now Jason will need to chime in with comments on the new unwind functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64993/new/ https://reviews.llvm.org/D64993 _

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 212615. JosephTremoulet added a comment. - Move resolution helper from RegisterContextLLDB to lldb_private::Address - Defensively initialize out arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:595-624 +bool RegisterContextLLDB::TryResolveSymbolContextAndAddressRange( +lldb_private::Address pc, lldb_private::SymbolContext &sym_ctx, +lldb_private::AddressRange

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:595-624 +bool RegisterContextLLDB::TryResolveSymbolContextAndAddressRange( +lldb_private::Address pc, lldb_private:

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

labath added a comment. I haven't looked at the implementation, but I did run into the problem you are fixing in the past, and I am happy that someone is finally implementing this. I just wanted to say that for testing, I think you should be able to create some hand-written assembly that create

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I will let Jason comment on the unwind specifics since this is his area. I caught a few other things that need to be cleaned up. Comment at: lldb/include/lldb/

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. @jasonmolenda @clayborg ping. To clarify, the issue this fixes is, using test functionalities/signal/handle-abrt as an example: #include #include #include void handler(int sig) { printf("Set a breakpoint here.\n"); exit(0); } v

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet marked 2 inline comments as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1760 +void RegisterContextLLDB::PropagateTrapHandlerFlag( +lldb::UnwindPlanSP unwind_plan) { + if (unwind_plan->Ge

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet created this revision. JosephTremoulet added reviewers: jasonmolenda, clayborg. Herald added a reviewer: jfb. Herald added a project: LLDB. Update StackFrame::GetSymbolContext to mirror the logic in RegisterContextLLDB::InitializeNonZerothFrame that knows not to do the pc decrement