[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

2019-07-31 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367392: SymbolVendor: Remove the object file member variable (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

2019-07-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D65401#1604870 , @clayborg wrote: > So previously the SymbolVendor would only make a strong reference to the > object file if it didn't match the object file of the module. Now it always > makes one. Might be ok since the

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

2019-07-29 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So previously the SymbolVendor would only make a strong reference to the object file if it didn't match the object file of the module. Now it always makes one. Might be ok since the Module owns the SymbolVendor and thus owns the SymbolFile. We should make sure we

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

2019-07-29 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. labath added a parent revision: D65329: SymbolVendor: Move locking into the Symbol Files. The last responsibility of the SymbolVendor was to hold an owning reference to the object file (in case symbols are