[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny abandoned this revision. mgorny added a comment. The problem is to complex too be implemented in smaller blocks. I'm going to close this in favor of a single unified patch in D64647 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:104 + // TODO: PTRACE_FORK | PTRACE_VFORK | PTRACE_POSIX_SPAWN? + events.pe_set_event = PTRACE_LWP_CREATE | PTRACE_LWP_EXIT; + status = PtraceWrapper(PT_SET_EVENT_MASK, pi

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny updated this revision to Diff 213231. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentBreakpointOneDelayBreakpointThreads.py lldb/packag

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked 6 inline comments as done. mgorny added a comment. @jfb, could you please remove your red flag now? ;-) Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:738 +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); + b

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); jingham wrote: >

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jingham added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); mgorny wrote

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb requested changes to this revision. jfb added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)-

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:738 +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); + break; Note to self, this should

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

labath added a comment. Looks fine to me. Minor comments inline. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:271 +} +SetState(StateType::eStateRunning, true); + } break; I don't think you need this. Given that you never repor

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a reviewer: jfb. mgorny added a parent revision: D64647: [lldb] [Process/NetBSD] Implement per-thread execution control. Herald added a subscriber: dexonsmith. // NB: Now, this patch is most likely correct. Ho