[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

This revision was automatically updated to reflect the committed changes. Closed by commit rL367994: SymbolVendorELF: Perform build-id lookup even without a debug link (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath updated this revision to Diff 213298. labath added a comment. - don't go off searching for separate files if the main one already contains debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65561/new/ https://reviews.llvm.org/D65561 Files: lit/Modules/ELF/build-id-case

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

jankratochvil added a comment. In D65561#1614293 , @labath wrote: > That would seem to at odds with your " .gnu_debuglink is considered as a > flag" assertion, but I am not sure how you came to believe that. I see I remembered it wrongly, already the in

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath added a comment. The "real" goal is being able to search for external debug files using the build-id without them having the gnu_debuglink thingy. :) That would seem to at odds with your " .gnu_debuglink is considered as a flag" assertion, but I am not sure how you came to believe that.

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. I find it as a performance regression that even with an unstripped full debug info file (clang -g) LLDB has now started to look for the separate debug info file based o

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath created this revision. labath added reviewers: jankratochvil, mgorny, clayborg. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. The debug link and build-id lookups are two independent ways one can search for a se