[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

JDevlieghere added a comment. After some brainstorming I've identified a few other approaches that should better reflect the transience of the current working directory: - We can modify the VFS to have a notion of //search paths//. The `adjustPath` function could iterate over the search paths u

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall added a comment. > I'd like to know if you tried other approaches and why they failed. +1. In particular, what goes wrong if you try to make the working directory a sibling of VFS (within the reproducer container) rather than a child of it (within shared infrastructure)? Repository:

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

labath added a comment. I just wanted to note that the CWD is not the only thing about a filesystem that's transient -- it's contents can change over time too. This is particularly important for a long-lived process like lldb, which explicitly supports things like rebuilding an executable and t

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

bruno added a comment. >> It seems conceptually a little strange to have the working directory be part >> of a serialized "FS", as it's fundamentally a property of a process and only >> transiently a property of the VFS. I tend to agree with @sammccall, it's odd that something that's usually

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

JDevlieghere added a comment. In D65677#1614595 , @sammccall wrote: > It seems conceptually a little strange to have the working directory be part > of a serialized "FS", as it's fundamentally a property of a process and only > transiently a property of

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Oops, didn't mean to mark as accepted. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 __

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It seems conceptually a little strange to have the working directory be part of a serialized "FS", as it's fundamentally a property of a process and only transiently a property of the VF

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

JDevlieghere created this revision. JDevlieghere added reviewers: bkramer, bruno, vsapsai, sammccall. Herald added subscribers: lldb-commits, dexonsmith, hiraditya. Herald added projects: LLDB, LLVM. For reproducers it is useful to encode the notion of the current working directory in the VFS map