This revision was automatically updated to reflect the committed changes.
Closed by commit rL368199: Add support for deterministically linked binaries on
macOS to lldb. (authored by nico, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commi
erikchen added a comment.
I do not have commit access. Can someone land the change for me? Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
___
lldb-commits mailing list
lldb-commits@lists.llv
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks, this LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
___
lldb-commits
erikchen marked 3 inline comments as done.
erikchen added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: i
erikchen updated this revision to Diff 213962.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/deterministic-build.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Index: lldb/source/Plugi
labath added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: int main() { return 0; }
erik
erikchen marked an inline comment as done.
erikchen added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6
+// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t
+// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck
%s
+// CHECK: i
erikchen updated this revision to Diff 213960.
erikchen marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
lldb/lit/SymbolFile/DWARF/determinis
JDevlieghere added inline comments.
Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:1
+// Test that binaries linked deterministically (N_OSO has timestamp 0) can
still
+// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE
Y
erikchen added a comment.
Okay, this is ready for another round of review when you have time. Thanks :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
___
lldb-commits mailing list
lldb-commits@list
erikchen updated this revision to Diff 213758.
erikchen added a comment.
Added a test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65826/new/
https://reviews.llvm.org/D65826
Files:
lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit
lldb/lit/SymbolFile/DWARF/determinist
JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.
I agree with Reid, change looks fine but this definitely needs a test.
The Python-style tests in `packages/Python/lldbsuite/test` give you the most
freedom as they use ma
rnk added a comment.
Code seems fine, I think this is probably the right fix, but this probably
deserves a test along the lines of what's in the commit message. I'm not
familiar with LLDB's test suite, so I can't give much guidance there.
Let's see if @JDevlieghere has input.
Repository:
rL
13 matches
Mail list logo
