[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

2019-08-08 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65874/new/ https://reviews.llvm.org/D65874 _

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

2019-08-08 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368294: [lldb][CMake] Disable modules in Xcode projects (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

2019-08-08 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Do we have a radar tracking the SourceKit issue? This *should* work and I'm curious if this is actually SourceKit or if this is just a broken LLVM+modules build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65874/new/

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

2019-08-07 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. You might want to check with Argyrios, maybe file a rdar against SourceKit. Otherwise, this is fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

2019-08-07 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: aprantl, jingham, davide, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. Apparently, module-enabled builds clash with Xcode's analysis. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65874