This revision was automatically updated to reflect the committed changes.
Closed by commit rL368614: [Symbol] GetTypeBitAlign() should return None in
case of failure. (authored by davide, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
aprantl added a comment.
Check LLVM's MathExtras.h, perhaps we already got one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66093/new/
https://reviews.llvm.org/D66093
___
lldb-commits mailing list
davide marked an inline comment as done.
davide added inline comments.
Comment at: lldb/source/Expression/Materializer.cpp:803
+
+ size_t byte_align = (*opt_bit_align + 7) / 8;
aprantl wrote:
> does this also need to be 7ull?
I'm going to move this to a
aprantl accepted this revision.
aprantl added inline comments.
Comment at: lldb/source/Expression/Materializer.cpp:803
+
+ size_t byte_align = (*opt_bit_align + 7) / 8;
does this also need to be 7ull?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
davide added a comment.
More than error handling, this allows us to distinguish with a type with zero
alignment (if possible at all?) and an error getting the alignment from
ASTContext/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66093/new/
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
I appreciate you adding more error handling. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66093/new/
davide created this revision.
davide added reviewers: xiaobai, compnerd.
Herald added a project: LLDB.
davide added a reviewer: aprantl.
And not `zero`. This is the last API needed to be converted to
an Optional.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D66093
Files:
