compnerd closed this revision.
compnerd added a comment.
SVN r369788
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66445/new/
https://reviews.llvm.org/D66445
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
The reason for the define is it’s not possible currently to include winnt.h
without build errors. Definitely something to cleanup.
> On Aug 22, 2019, at 9:47 AM, Gwen Mittertreiner via Phabricator
> wrote:
>
> jmittert added a comment.
>
> I believe it's using the one in ntstatus.h
>
> 10.0
jmittert added a comment.
I believe it's using the one in ntstatus.h
10.0.16299.0\shared\ntstatus.h
#define STATUS_BREAKPOINT((NTSTATUS)0x8003L)// winnt
And `NTSTATUS` is defined as a `LONG` in powerbase.h
10.0.16299.0\um\powerbase.h
#define NTSTATUS LONG
which
amccarth added a comment.
Is this necessary? I see
C++
#define STATUS_BREAKPOINT((DWORD )0x8003L)
#define STATUS_SINGLE_STEP ((DWORD )0x8004L)
in C:\Program Files (x86)\Windows Kits\8.1\Include\um\winnt.h
Repository:
rLLDB LLDB
CHANGES SINCE
jmittert created this revision.
jmittert added reviewers: xiaobai, labath, JDevlieghere, asmith.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8-- which
is negative and thus can't be implicitly narrowed to a DWO
