This revision was automatically updated to reflect the committed changes.
Closed by commit rL369885: [lldb] Construct the dummy target when the first
Debugger object is constructed (authored by teemperor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Chang
jingham accepted this revision.
jingham added a comment.
You can go a long time without actually using the Dummy target, which is why I
made it lazily.
Thinking of lldb as the command line program, we tend to think "I'll only ever
make one debugger" so making one extra per-debugger thing doesn'
teemperor updated this revision to Diff 216581.
teemperor added a comment.
- Fix variable name.
- Move GetDummyTarget to header as it's only a one-liner.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66581/new/
https://reviews.llvm.org/D66581
Files:
lldb/include/lldb/Core/Debugger.h
labath added a reviewer: jingham.
labath accepted this revision.
labath added a subscriber: jingham.
labath added a comment.
This revision is now accepted and ready to land.
This looks good to me (I wanted to do something like that myself at one point),
but maybe let @jingham have a say too. (Ove
teemperor created this revision.
teemperor added a reviewer: labath.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.
We should always have a dummy target, so we might as well construct it directly
when we create a Debugger object.
The idea is that if this patch doesn
