[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath added a comment. In D66634#1648119 , @amccarth wrote: > When I added my comments, Phabricator showed this patch as still open. Now > it looks like it landed four hours before that. :-( Yeah, :(, but that doesn't mean I can't address any

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

amccarth added a comment. When I added my comments, Phabricator showed this patch as still open. Now it looks like it landed four hours before that. :-( Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66634/new/ https://reviews.llvm.org/D66634

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath marked 3 inline comments as done. labath added a comment. Please find my replies inline (including my yesterday's reply to Aleksandr, which I apparently failed to submit). Comment at: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:61

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

amccarth added a comment. I have a couple inline questions. After that, it looks fine. Comment at: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:61 + for (auto it = parsed.begin(), end = parsed.end(); it != end; ++it) { // Emplace

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL369894: Postfix: move more code out of the PDB plugin (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:58 llvm::BumpPtrAllocator

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath created this revision. labath added reviewers: amccarth, aleksandr.urakov. Herald added a subscriber: aprantl. Previously we moved the code which parses a single expression out of the PDB plugin, because that was useful for DWARF expressions in breakpad. However, FPO programs are used in