[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil planned changes to this revision. jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/ValueObject.h:460 + // Store error from Expected<> parameter unless some error is already stored. + template

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

labath added a comment. In D66654#1645792 , @jankratochvil wrote: > In D66654#1645658 , @clayborg wrote: > > > What about having the first one that matched being the one that is used and > > avoid errors all toget

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil added a comment. In D66654#1645658 , @clayborg wrote: > What about having the first one that matched being the one that is used and > avoid errors all together? This is how it worked so far before the fix D66398

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

clayborg added a comment. What about having the first one that matched being the one that is used and avoid errors all together? We do this with the regex alias stuff already. With regular expressions people are sure to make ones that conflict with each other. Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. + @jingham for value object stuff Though I agree with the general principle of this change, the new api which implements it seems extremely confusing. Unfortunately, it's not really clear to me how to

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217079. jankratochvil added a comment. Testcase for the regex sanity check is failing - `ValueObject::m_error` remains set even after `type summary clear`. `ValueObject::UpdateValueIfNeeded` will find `did_change_formats==true` but it does not help it.

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217053. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/DataFormatters/FormatClasses.h lldb/include/lldb/Data

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217052. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/DataFormatters/FormatClasses.h lldb/include/lldb/Data

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil marked 5 inline comments as done. jankratochvil added a comment. In D66654#1643082 , @JDevlieghere wrote: > How much work would it be to return an `llvm::Expected` from > `Get_Impl`? I'd really prefer that over the current approach. Done.

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

granata.enrico resigned from this revision. granata.enrico added a comment. I'm not working on LLDB anymore. Sorry about that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 __

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. > I understand one could pass some better abstracted error-reporting interface > instead of ValueObject itself but that would require some more code > (interface definiti

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil created this revision. jankratochvil added reviewers: labath, JDevlieghere, granata.enrico. jankratochvil added a project: LLDB. Herald added a subscriber: lldb-commits. The sanity checking part is improved here to use some