[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

davezarzycki added a comment. Great. See: r371596 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67230/new/ https://reviews.llvm.org/D67230 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

labath added a comment. In D67230#1661120 , @serge-sans-paille wrote: > @davezarzycki I tend to agree with you. We can just remove 35:44 and just > keep the hostname. sounds good to me Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille added a comment. @davezarzycki I tend to agree with you. We can just remove 35:44 and just keep the hostname. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67230/new/ https://reviews.llvm.org/D67230

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

davezarzycki added a comment. This code is trying too hard and failing. Either the result of gethostname() is canonical or it is not. If it is not, then trying to canonicalize it is – for various reasons – a lost cause. For example, a given machine might have multiple network interfaces with

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL371195: Remove call to obsolete gethostbyname, using getaddrinfo (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea, particularly as gethostbyname is not thread safe. It seems getaddrinfo is already used in lldb, so it should be supported by all OSs that we care about. Repository:

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille created this revision. serge-sans-paille added a reviewer: k8stone. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. >From the man page: > The gethostbyname*() and gethostbyaddr*() functions are obsolete. > Applications should use getaddrinfo(3) and