This revision was automatically updated to reflect the committed changes.
Closed by commit rL371258: [Core] Remove use of ClangASTContext in
DumpDataExtractor (authored by xiaobai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
xiaobai updated this revision to Diff 219145.
xiaobai added a comment.
Refactored slightly to be a bit safer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67239/new/
https://reviews.llvm.org/D67239
Files:
xiaobai added a comment.
Hmm, good question. If you call `GetAPInt` with a `byte_size` of 0, it should
assert when trying to read 0 bytes with the `DataExtractor`. In the worst case,
it gives you a broken APInt. I think guarded the call to `GetAPInt` to protect
against this, but I think that
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks like a good improvement.
Does the `APFloatBase::Bogus` result of `GetFloatTypeSemantics` affect the
functional behavior of the `DumpDataExtractor ` or does `GetAPInt` just
xiaobai created this revision.
xiaobai added reviewers: clayborg, JDevlieghere, jingham.
Herald added a project: LLDB.
DumpDataExtractor uses ClangASTContext in order to get the proper llvm
fltSemantics for the type it needs so that it can dump floats in a more
precise way. However, there's no
