labath added a comment.
Cool stuff. I wanted to do this for a while. Thanks.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67984/new/
https://reviews.llvm.org/D67984
___
lldb-commits mailing list
lldb-commits@lists.ll
JDevlieghere added a comment.
Hey Adrian,
I've reverted two changes in r372801 that appear to break the linux bots:
http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/2405
http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/4417
Can you have a look?
Repository:
rL LLVM
CHA
This revision was automatically updated to reflect the committed changes.
Closed by commit rL372795: Canonicalize variable usage in testsuite Makefiles
(authored by adrian, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67984/new/
https://reviews.llvm.org/D67984
___
lldb-commits mailing list
aprantl updated this revision to Diff 221613.
aprantl added a comment.
Address feedback from Jonas.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67984/new/
https://reviews.llvm.org/D67984
Files:
lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile
lldb/packages/Python/ll
aprantl added a comment.
I checked, and Makefile.rules does initialize CXXFLAGS lazily, but it's still
better to not depend on that implementation detail.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67984/new/
https://reviews.llvm.org/D67984
___
JDevlieghere added a comment.
A few things that need checking/reordering, but otherwise great cleanup!
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile:4
include Makefile.rules
-CXXFLAGS += -O0
+CXXFLAGS_E
aprantl updated this revision to Diff 221592.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67984/new/
https://reviews.llvm.org/D67984
Files:
lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile
lldb/packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/Makefile
aprantl created this revision.
aprantl added reviewers: jasonmolenda, JDevlieghere, labath.
Herald added subscribers: arphaman, christof.
This test streamlines our use of variables that are expected by Makefile.rules
throughout the test suite. Mostly it replaced potentially dangerous overrides
a
