JosephTremoulet updated this revision to Diff 18.
JosephTremoulet added a comment.
- Move artificial SIGSTOP injection to RefreshStateAfterStop
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68096/new/
https://reviews.llvm.org/D68096
Files:
l
JosephTremoulet marked an inline comment as done.
JosephTremoulet added a comment.
> Fortunately, for the functionality you're testing, I don't think you really
> need the executable file, so you can just ignore the elf bit and test with a
> plain `lldb -c foo.dmp` (obviously, you won't get the
labath added a comment.
The functionality is fine, though I'd hope it can be cleaned up a bit.
As for testing, yes, yaml2obj has some problems roundtripping complex minidumps
(and elf files). Fortunately, for the functionality you're testing, I don't
think you really need the executable file, s
JosephTremoulet added a comment.
I'm trying to fix an issue where opening a minidump created by breakpad in lldb
just hangs, but if I use breakpad's minidump-2-core on that same dump then
opening the core dump works fine. From debugging the two cases I can see that
the critical logic that Proc
JosephTremoulet created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Set the UnixSignals object when isOSLinux is true, and force a SIGSTOP
if there's no other signal when loading a core dump (the same as
ProcessElfCore::DoLoadCore does) since the loading p
