[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

2019-10-09 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0156be59b45d: Fix a crasher due to an assert when two files have the same UUID but different… (authored by clayborg). Changed prior to commit: https://reviews.llvm.org/D68106?vs=222032=224185#toc

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

2019-09-27 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, modulo the comment about shadowing. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:115 + lldb::addr_t GetBaseAddress() const { return

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

2019-09-26 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, aadsm, dvlahovski. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. clayborg updated this revision to Diff 222032. clayborg added a comment. Remove printf that was left in. The PlaceholderObjectFile has an

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

2019-09-26 Thread Greg Clayton via Phabricator via lldb-commits
clayborg updated this revision to Diff 222032. clayborg added a comment. Remove printf that was left in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68106/new/ https://reviews.llvm.org/D68106 Files: