[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da2bc22badd: remove a smattering of isolated, unnecessary uses of FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/ne

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223981. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/source/API/SBDebugger.cpp lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223392. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/source/API/SBDebugger.cpp lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223254. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/sour

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the stream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

labath added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:332 + if (m_output_sp) { +m_output_sp->GetFile().Printf("%s", prompt); +m_output_sp->Flush(); It looks like this could actually use the `Stream` interface to

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. There a a few call sites that use FILE* which are easy to fix without disrupting anything else. Repository: rG LLVM Github Monorepo https://reviews.llvm.org