[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

nickdesaulniers added a comment. Sounds like another approach was landed in https://reviews.llvm.org/D69403, and a follow up in https://reviews.llvm.org/D70277, and 9a3f892d018238dce5181e458905311db8e682f5 . Repository:

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk added a comment. Reverted in d0bd3fc88be . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added inline comments. Comment at: lldb/tools/driver/Driver.cpp:850 #if !defined(_MSC_VER) signal(SIGPIPE, SIG_IGN); signal(SIGWINCH, sigwinch_handler); vsk wrote: > labath wrote: > > vsk wrote: > > > labath wrote: > > > > I don't think this line

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added a comment. I admit I hadn't paid enough attention to the order in which signal handlers were registered in lldb. Comment at: lldb/tools/driver/Driver.cpp:850 #if !defined(_MSC_VER) signal(SIGPIPE, SIG_IGN);

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1717453 , @labath wrote: > I'm not too worried about adding those tests here. I'm not too worried about *not* adding those tests here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1717361 , @vsk wrote: > A problem I'm encountering with this is that the static initializer from > Signals.inc don't appear to be re-run between death tests. This makes the > death tests pretty brittle, imo, as swapping

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added a comment. In D69148#1715532 , @labath wrote: > In D69148#1714785 , @vsk wrote: > > > The death tests are flaky. I've noticed two issues: > > > > 1. When run under

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1714785 , @vsk wrote: > The death tests are flaky. I've noticed two issues: > > 1. When run under lit, the DisableExitOnSIGPIPE doesn't actually exit when it > receives SIGPIPE. Dtrace suggests that the unit test process

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG32ce14e55e5a: Disable exit-on-SIGPIPE in lldb (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk updated this revision to Diff 225661. vsk added a comment. This revision is now accepted and ready to land. Replace the death tests with a non-death test. I plan to commit this later in the day if there aren't any objections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk planned changes to this revision. vsk added a comment. The death tests are flaky. I've noticed two issues: 1. When run under lit, the DisableExitOnSIGPIPE doesn't actually exit when it receives SIGPIPE. Dtrace suggests that the unit test process inherits an "ignore" sigaction from its

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jordan_rose added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) + CurrentPipeFunction(); vsk wrote:

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for fixing this, Vedant! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) +

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jordan_rose added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) + CurrentPipeFunction(); Should it

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb accepted this revision. jfb added a subscriber: jordan_rose. jfb added a comment. This revision is now accepted and ready to land. More of an FYI, @jordan_rose might be interested in this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk updated this revision to Diff 225546. vsk edited the summary of this revision. vsk added a comment. - Allow setting a SIGPIPE handler. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 Files: lldb/tools/driver/Driver.cpp

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk planned changes to this revision. vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/tools/driver/Driver.cpp:864 + // in LLDB leaves behind temporary objects). + llvm::sys::SetExitOnFailedPipeWrite(/*ExitOnFailedWrite=*/false); +

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb added inline comments. Comment at: lldb/tools/driver/Driver.cpp:864 + // in LLDB leaves behind temporary objects). + llvm::sys::SetExitOnFailedPipeWrite(/*ExitOnFailedWrite=*/false); + Could this instead pass a lambda, like other signal handlers? So

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk created this revision. vsk added reviewers: jfb, nickdesaulniers, friss, JDevlieghere. Herald added subscribers: dexonsmith, hiraditya, mgorny. Herald added a project: LLVM. Occasionally, during test teardown, there is a write to a closed pipe in of LLDB's handful of IPC channels. Sometimes