This revision was automatically updated to reflect the committed changes.
Closed by commit rGa69bbe02a235: [LLDB][breakpoints] ArgInfo::count -
ArgInfo::max_positional_args (authored by lawrence_danna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lawrence_danna marked 4 inline comments as done.
lawrence_danna added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:76-79
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
+
+extern
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine, though I'd try to remove the `extern "C"` thingy to avoid the need
to supress warnings and stuff...
Comment at:
lawrence_danna updated this revision to Diff 226737.
lawrence_danna added a comment.
improved error handling
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69468/new/
https://reviews.llvm.org/D69468
Files:
In the work I was doing with the scripted ThreadPlans & Breakpoint Callbacks,
I've been introducing Status objects into these calls in python-wrapper.swig
(usually you have to start from the ScriptInterpreter API's, so we can report
errors. That way I could catch errors with wrong number of
labath added inline comments.
Comment at: lldb/scripts/Python/python-wrapper.swig:64
+unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED;
+if (auto arg_info = pfunc.GetArgInfo()) {
lawrence_danna wrote:
> labath wrote:
> > Is there any
lawrence_danna marked an inline comment as done.
lawrence_danna added inline comments.
Comment at: lldb/scripts/Python/python-wrapper.swig:64
+unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED;
+if (auto arg_info = pfunc.GetArgInfo()) {
labath added inline comments.
Comment at: lldb/scripts/Python/python-wrapper.swig:64
+unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED;
+if (auto arg_info = pfunc.GetArgInfo()) {
Is there any case where fetching the argument info will
lawrence_danna created this revision.
lawrence_danna added reviewers: labath, jingham, JDevlieghere.
Herald added a project: LLDB.
Move breakpoints from the old, bad ArgInfo::count to the new, better
ArgInfo::max_positional_args. Soon ArgInfo::count will be no more.
It looks like this
