[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

This revision was automatically updated to reflect the committed changes. Closed by commit rGadbf64ccc9e1: [LLDB][Python] remove ArgInfo::count (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69742/new/

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. In D69742#1732608 , @labath wrote: > At this point, should we just delete the ArgInfo struct altogether, and > replace it with a plain `unsigned`? Sounds like a good idea

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

JDevlieghere added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 lawrence_danna wrote: > JDevlieghere wrote: > > Should we check `has_varargs` here

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 JDevlieghere wrote: > Should we

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 Should we check

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. At this point, should we just delete the ArgInfo struct altogether, and replace it with a plain `unsigned`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny, JDevlieghere. Herald added a project: LLDB. This patch updates the last user of ArgInfo::count and deletes it. I also delete `GetNumInitArguments()` and `GetInitArgInfo()`. Classess are callables and