[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

2019-11-05 Thread serge via Phabricator via lldb-commits
serge-sans-paille added a comment. Thanks for the fix o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69846/new/ https://reviews.llvm.org/D69846 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

2019-11-05 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3ae1eb296d: [lldb] [Python] Build readline override module only on Linux (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

2019-11-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69846/new/ https://reviews.llvm.org/D69846 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

2019-11-05 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: serge-sans-paille, labath, JDevlieghere, krytarowski. Restrict building the readline override to Linux only. It both does not build on *BSD systems, and is largely irrelevant since they default to using libedit over readline anyway. This rest