[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7c528d7ac1: [lldb-vscode] support the completion request (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228937. wallace added a comment. set a return list limit of 50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/ https://reviews.llvm.org/D69873 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-v

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

clayborg added a comment. Maybe limit the matches if posssible if that works. If you type "target variable " you can complete a list of all global variables everywhere which might be quite a few. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228078. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228076. wallace added a comment. removed the results limit of 20 because it didn't work and I verified that returning a long list is displayed well on vscode. There's no need for this limit at this point. I also tested the cases that @teemperor mentioned and

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

teemperor added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:948 +actual_column, +0, 20, matches, descriptions); + targets.reserve(matches.GetSize()); max_return_elements isn't implemented, so you can just pass '-1' here. This als

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace edited the summary of this revision. The DAP has a completion request that has been unimplemented. It allows showing autocompletion tokens inside